tty: rocket: fix invalid user-pointer checks

Drop invalid user-pointer checks from custom ioctl handlers.

A NULL-pointer can be valid in user space and copy_to_user() takes care
of sanity checking.

Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/tty/rocket.c b/drivers/tty/rocket.c
index b0cc47c..d66c1ed 100644 (file)
--- a/drivers/tty/rocket.c
+++ b/drivers/tty/rocket.c
@@ -1189,8 +1189,6 @@ static int get_config(struct r_port *info, struct rocket_config __user *retinfo)
 {
        struct rocket_config tmp;
 
-       if (!retinfo)
-               return -EFAULT;
        memset(&tmp, 0, sizeof (tmp));
        mutex_lock(&info->port.mutex);
        tmp.line = info->line;
@@ -1255,8 +1253,6 @@ static int get_ports(struct r_port *info, struct rocket_ports __user *retports)
        struct rocket_ports tmp;
        int board;
 
-       if (!retports)
-               return -EFAULT;
        memset(&tmp, 0, sizeof (tmp));
        tmp.tty_major = rocket_driver->major;