Fixed UTC for ewk_view_add_with_session_data.
authorFilip Piechocki <f.piechocki@samsung.com>
Tue, 16 Dec 2014 14:03:40 +0000 (15:03 +0100)
committerYoungsoo Choi <kenshin.choi@samsung.com>
Tue, 10 Jul 2018 06:57:09 +0000 (06:57 +0000)
The test was expecting that the webview won't be created
for the NULL session data, while according to WebKit-EFL code,
this should create empty webview. Current implementation
does exactly this, so the test case had to be fixed.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9537
Reviewed by: Piotr Tworek, SeungSeop Park
Reviewed by: Janusz Majnert, Piotr Tworek, SeungSeop Park, commitbot

Change-Id: I50d64f7083457c834aba4bd2338d22dfdf48c056
Signed-off-by: Filip Piechocki <f.piechocki@samsung.com>
tizen_src/ewk/unittest/utc_blink_ewk_view_add_with_session_data_func.cpp

index 19b7238..26459db 100755 (executable)
@@ -53,8 +53,8 @@ TEST_F(utc_blink_ewk_view_add_with_session_data_func, POS_TEST)
   ewk_view_back(GetEwkWebView());
   ASSERT_EQ(EventLoopStart(), Success);
 
-  ASSERT_TRUE(ewk_view_forward_possible(GetEwkWebView()) && "before");
-  ASSERT_TRUE(ewk_view_back_possible(GetEwkWebView()) && "before");
+  ASSERT_TRUE(ewk_view_forward_possible(GetEwkWebView())) << "before";
+  ASSERT_TRUE(ewk_view_back_possible(GetEwkWebView())) << "before";
 
   unsigned length = 0;
   ewk_view_session_data_get(GetEwkWebView(), &sessionData, &length);
@@ -66,8 +66,8 @@ TEST_F(utc_blink_ewk_view_add_with_session_data_func, POS_TEST)
   ASSERT_TRUE(otherWebview);
 
   ASSERT_STREQ(testUrl.c_str(), ewk_view_url_get(otherWebview));
-  ASSERT_TRUE(ewk_view_forward_possible(otherWebview) && "after");
-  ASSERT_TRUE(ewk_view_back_possible(otherWebview) && "after");
+  ASSERT_TRUE(ewk_view_forward_possible(otherWebview)) << "after";
+  ASSERT_TRUE(ewk_view_back_possible(otherWebview)) << "after";
 }
 
 /**
@@ -88,11 +88,11 @@ TEST_F(utc_blink_ewk_view_add_with_session_data_func, NEG_TEST_NULL_EVAS)
 /**
  * @brief Tests if returns NULL when called with NULL data.
  */
-TEST_F(utc_blink_ewk_view_add_with_session_data_func, NEG_TEST_NULL_DATA)
+TEST_F(utc_blink_ewk_view_add_with_session_data_func, POS_TEST_NULL_DATA)
 {
   const char *data = NULL;
   unsigned length = 0;
-  ASSERT_FALSE(ewk_view_add_with_session_data(GetEwkEvas(), data, length));
+  ASSERT_TRUE(ewk_view_add_with_session_data(GetEwkEvas(), data, length) != NULL);
 }
 
 /**