arm: dts: calxeda: Fix interrupt grouping
authorAndre Przywara <andre.przywara@arm.com>
Fri, 28 Feb 2020 13:51:04 +0000 (13:51 +0000)
committerArnd Bergmann <arnd@arndb.de>
Thu, 26 Mar 2020 09:52:28 +0000 (10:52 +0100)
Currently multiple interrupts for some devices are written as one array
instead of using the DT grouping notation (<0 42 4>, <0 23 4>).
This ends up in the same binary representation in the .dtb, but is
semantically not equivalent. The yaml schema checks will stumble over
this, so lets fix that first.

I refrained from using the symbolic names for GIC_SPI/GIC_PPI and
IRQ_TYPE_LEVEL_HIGH, mostly because it increases the delta between the
original DTS files and the mainline versions, so it's just additional
churn.

Link: https://lore.kernel.org/r/20200228135106.220620-4-andre.przywara@arm.com
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
arch/arm/boot/dts/ecx-2000.dts
arch/arm/boot/dts/ecx-common.dtsi
arch/arm/boot/dts/highbank.dts

index 8e04896..f6eb715 100644 (file)
@@ -93,7 +93,7 @@
 
                pmu {
                        compatible = "arm,cortex-a9-pmu";
-                       interrupts = <0 76 4  0 75 4  0 74 4  0 73 4>;
+                       interrupts = <0 76 4>, <0 75 4>, <0 74 4>, <0 73 4>;
                };
        };
 };
index f819e33..b7e74a3 100644 (file)
                ethernet@fff50000 {
                        compatible = "calxeda,hb-xgmac";
                        reg = <0xfff50000 0x1000>;
-                       interrupts = <0 77 4  0 78 4  0 79 4>;
+                       interrupts = <0 77 4>, <0 78 4>, <0 79 4>;
                        dma-coherent;
                };
 
                ethernet@fff51000 {
                        compatible = "calxeda,hb-xgmac";
                        reg = <0xfff51000 0x1000>;
-                       interrupts = <0 80 4  0 81 4  0 82 4>;
+                       interrupts = <0 80 4>, <0 81 4>, <0 82 4>;
                        dma-coherent;
                };
 
index 9e34d1b..b6b0225 100644 (file)
 
                pmu {
                        compatible = "arm,cortex-a9-pmu";
-                       interrupts = <0 76 4  0 75 4  0 74 4  0 73 4>;
+                       interrupts = <0 76 4>, <0 75 4>, <0 74 4>, <0 73 4>;
                };
 
 
                sregs@fff3c200 {
                        compatible = "calxeda,hb-sregs-l2-ecc";
                        reg = <0xfff3c200 0x100>;
-                       interrupts = <0 71 4  0 72 4>;
+                       interrupts = <0 71 4>, <0 72 4>;
                };
 
        };