net: dsa: mv88e6xxx: use mv88e6xxx_phy_is_internal in mv88e6xxx_port_ppu_updates
authorAlexis Lothoré <alexis.lothore@bootlin.com>
Mon, 29 May 2023 08:02:42 +0000 (10:02 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 31 May 2023 06:54:33 +0000 (23:54 -0700)
Make sure to use existing helper to get internal PHYs count instead of
redoing it manually

Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/mv88e6xxx/chip.c

index e6f6c06..1b5a05f 100644 (file)
@@ -477,7 +477,7 @@ static int mv88e6xxx_port_ppu_updates(struct mv88e6xxx_chip *chip, int port)
         * report whether the port is internal.
         */
        if (chip->info->family == MV88E6XXX_FAMILY_6250)
-               return port < chip->info->num_internal_phys;
+               return mv88e6xxx_phy_is_internal(chip, port);
 
        err = mv88e6xxx_port_read(chip, port, MV88E6XXX_PORT_STS, &reg);
        if (err) {