elm/list: remove max size setting on item contents
authorMike Blumenkrantz <zmike@samsung.com>
Tue, 24 Jul 2018 15:05:13 +0000 (11:05 -0400)
committerYoungbok Shin <youngb.shin@samsung.com>
Thu, 26 Jul 2018 08:26:36 +0000 (17:26 +0900)
Summary:
this was added in a giant block commit in 2009 without direct explanation;
it doesn't seem to make functional sense in the original patch and it
definitely doesn't make sense now

this greatly improves list performance by causing fewer edje recalcs on
list items resulting from list fighting with item content objects over
max size hint

fix T7176

Reviewers: Hermet

Reviewed By: Hermet

Subscribers: cedric, #committers

Tags: #efl_widgets

Maniphest Tasks: T7176

Differential Revision: https://phab.enlightenment.org/D6669

src/lib/elementary/elm_list.c

index 7cfb09f..5bce890 100644 (file)
@@ -1032,14 +1032,12 @@ _items_fix(Evas_Object *obj)
         if (it->icon)
           {
              evas_object_size_hint_min_set(it->icon, minw[0], minh[0]);
-             evas_object_size_hint_max_set(it->icon, 99999, 99999);
              edje_object_part_swallow
                 (VIEW(it), "elm.swallow.icon", it->icon);
           }
         if (it->end)
           {
              evas_object_size_hint_min_set(it->end, minw[1], minh[1]);
-             evas_object_size_hint_max_set(it->end, 99999, 99999);
              edje_object_part_swallow
                 (VIEW(it), "elm.swallow.end", it->end);
           }