ide-tape: fix misprint in failure handling in idetape_init()
authorAlexey Khoroshilov <khoroshilov@ispras.ru>
Fri, 29 Apr 2016 22:11:12 +0000 (01:11 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 26 Jul 2016 22:25:30 +0000 (15:25 -0700)
If driver_register() failed there is no sense to call driver_unregister().
unregister_chrdev() should be called here.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/ide/ide-tape.c

index 12fa049..9ecf4e3 100644 (file)
@@ -2052,12 +2052,12 @@ static int __init idetape_init(void)
 
        error = driver_register(&idetape_driver.gen_driver);
        if (error)
-               goto out_free_driver;
+               goto out_free_chrdev;
 
        return 0;
 
-out_free_driver:
-       driver_unregister(&idetape_driver.gen_driver);
+out_free_chrdev:
+       unregister_chrdev(IDETAPE_MAJOR, "ht");
 out_free_class:
        class_destroy(idetape_sysfs_class);
 out: