Fix use of qMax() with floating point constants
authorSergio Ahumada <sergio.ahumada@nokia.com>
Sun, 30 Oct 2011 17:41:51 +0000 (18:41 +0100)
committerQt by Nokia <qt-info@nokia.com>
Sun, 30 Oct 2011 19:24:37 +0000 (20:24 +0100)
When passing floating point constants make sure
to cast them as qreal's.

Change-Id: I17e7ee407ac4f92ce947f6a384aa4d64edb8e983
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
src/gui/painting/qcosmeticstroker.cpp
src/widgets/styles/qstylehelper.cpp

index eb00ec8..d591c34 100644 (file)
@@ -258,12 +258,12 @@ void QCosmeticStroker::setup()
 
         patternLength = 0;
         for (int i = 0; i < patternSize; ++i) {
-            patternLength += (int) qMax(1. , penPattern.at(i)*64.);
+            patternLength += (int) qMax(qreal(1.) , penPattern.at(i)*64.);
             pattern[i] = patternLength;
         }
         patternLength = 0;
         for (int i = 0; i < patternSize; ++i) {
-            patternLength += (int) qMax(1., penPattern.at(patternSize - 1 - i)*64.);
+            patternLength += (int) qMax(qreal(1.), penPattern.at(patternSize - 1 - i)*64.);
             reversePattern[i] = patternLength;
         }
         strokeSelection |= Dashed;
index bf7cb49..c870ec8 100644 (file)
@@ -246,7 +246,7 @@ void drawDial(const QStyleOptionSlider *option, QPainter *painter)
 
     if (enabled) {
         // Drop shadow
-        qreal shadowSize = qMax(1.0, penSize/2.0);
+        qreal shadowSize = qMax(qreal(1.0), penSize/2.0);
         QRectF shadowRect= br.adjusted(-2*shadowSize, -2*shadowSize,
                                        2*shadowSize, 2*shadowSize);
         QRadialGradient shadowGradient(shadowRect.center().x(),