pkgconfig: don't put -DG_THREADS_MANDATORY into our pkg-config CFLAGS
authorTim-Philipp Müller <tim.muller@collabora.co.uk>
Fri, 29 Jan 2010 09:41:30 +0000 (09:41 +0000)
committerTim-Philipp Müller <tim.muller@collabora.co.uk>
Sat, 30 Jan 2010 12:50:09 +0000 (12:50 +0000)
If we force -DG_THREADS_MANDATORY onto apps, then g_thread_supported()
will always evaluate to TRUE, so the typical thread initialisation
boilerplate code if (!g_thread_supported()) g_thread_init(NULL); will
no longer work, and the threading system not be initialised and us
printing a warning in gst_init. This may be fine in most cases, since
late initialisation is allowed and automatically done in g_type_init()
since GLib 2.23.2, but let's be cautious and only use this define when
compiling GStreamer itself.

See #608398.

pkgconfig/gstreamer-uninstalled.pc.in
pkgconfig/gstreamer.pc.in

index 674b30db55c2fb398bfbe1711b2d13d19d675ecd..fa518cd0334f7b0b9e5b640010b2e9ce3c2d849c 100644 (file)
@@ -11,4 +11,4 @@ Description: Streaming media framework, Not Installed
 Version: @VERSION@
 Requires: @GST_PKG_DEPS@@LIBXML_PKG@
 Libs: ${libdir}/gst/libgstreamer-@GST_MAJORMINOR@.la
-Cflags: -I${includedir}  -I@srcdir@/.. -I${includedir}/libs  -I@srcdir@/../libs -DG_THREADS_MANDATORY
+Cflags: -I${includedir}  -I@srcdir@/.. -I${includedir}/libs  -I@srcdir@/../libs
index 3cbe181f6bed068a038268b31d09ff2cec8f46d7..32fd81182d4fb4fe6c9837a554fb6197730eba98 100644 (file)
@@ -10,4 +10,4 @@ Description: Streaming media framework
 Requires: @GST_PKG_DEPS@@LIBXML_PKG@
 Version: @VERSION@
 Libs: -L${libdir} -lgstreamer-@GST_MAJORMINOR@
-Cflags: -I${includedir} -DG_THREADS_MANDATORY
+Cflags: -I${includedir}