staging: unisys: visorbus: chipset_init add error handling
authorDavid Kershner <david.kershner@unisys.com>
Mon, 21 Nov 2016 17:15:45 +0000 (12:15 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Nov 2016 09:01:56 +0000 (10:01 +0100)
Controlvm_respond_chipset_init now errors out correctly. Pass the errors
back up to the stack to be processed.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visorbus/visorchipset.c

index e982a46..331f6b1 100644 (file)
@@ -511,16 +511,18 @@ controlvm_respond_chipset_init(struct controlvm_message_header *msg_hdr,
                                         CONTROLVM_QUEUE_REQUEST, &outmsg);
 }
 
-static void
+static int
 chipset_init(struct controlvm_message *inmsg)
 {
        static int chipset_inited;
        enum ultra_chipset_feature features = 0;
        int rc = CONTROLVM_RESP_SUCCESS;
+       int res = 0;
 
        POSTCODE_LINUX_2(CHIPSET_INIT_ENTRY_PC, POSTCODE_SEVERITY_INFO);
        if (chipset_inited) {
                rc = -CONTROLVM_RESP_ERROR_ALREADY_DONE;
+               res = -EIO;
                goto out_respond;
        }
        chipset_inited = 1;
@@ -541,7 +543,9 @@ chipset_init(struct controlvm_message *inmsg)
 
 out_respond:
        if (inmsg->hdr.flags.response_expected)
-               controlvm_respond_chipset_init(&inmsg->hdr, rc, features);
+               res = controlvm_respond_chipset_init(&inmsg->hdr, rc, features);
+
+       return res;
 }
 
 static void