ionic: change mtu after queues are stopped
authorShannon Nelson <snelson@pensando.io>
Tue, 1 Dec 2020 00:25:46 +0000 (16:25 -0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 2 Dec 2020 01:14:23 +0000 (17:14 -0800)
Order of operations is slightly more correct in the driver
to change the netdev->mtu after the queues have been stopped
rather than before.

Signed-off-by: Shannon Nelson <snelson@pensando.io>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/pensando/ionic/ionic_lif.c

index 0b7f2de..1114091 100644 (file)
@@ -1465,12 +1465,14 @@ static int ionic_change_mtu(struct net_device *netdev, int new_mtu)
        if (err)
                return err;
 
-       netdev->mtu = new_mtu;
        /* if we're not running, nothing more to do */
-       if (!netif_running(netdev))
+       if (!netif_running(netdev)) {
+               netdev->mtu = new_mtu;
                return 0;
+       }
 
        ionic_stop_queues_reconfig(lif);
+       netdev->mtu = new_mtu;
        return ionic_start_queues_reconfig(lif);
 }