Advise against using GPrivate

GStaticPrivate is really a lot better in almost every way.

diff --git a/glib/gthread.c b/glib/gthread.c
index 44075b698d30e9b3ceb7bd6d4804353842314a0e..58d76c763fd180088fc575ce1a95371072584821 100644 (file)
--- a/glib/gthread.c
+++ b/glib/gthread.c
@@ -682,6 +682,10 @@ GThreadFunctions g_thread_functions_for_glib_use = {
 /**
  * GPrivate:
  *
+ * <note><para>
+ * #GStaticPrivate is a better choice for most uses.
+ * </para></note>
+ *
  * The #GPrivate struct is an opaque data structure to represent a
  * thread private data key. Threads can thereby obtain and set a
  * pointer which is private to the current thread. Take our
@@ -741,6 +745,10 @@ GThreadFunctions g_thread_functions_for_glib_use = {
  * non-%NULL, the destructor is called with this pointer as the
  * argument.
  *
+ * <note><para>
+ * #GStaticPrivate is a better choice for most uses.
+ * </para></note>
+ *
  * <note><para>@destructor is used quite differently from @notify in
  * g_static_private_set().</para></note>
  *