flacdec: Correct sample number rounding resulting in timestamp jitter
authorMonty Montgomery <cmontgom@redhat.com>
Thu, 21 Jul 2011 21:23:28 +0000 (17:23 -0400)
committerSebastian Dröge <sebastian.droege@collabora.co.uk>
Tue, 23 Aug 2011 08:09:41 +0000 (10:09 +0200)
flacdec converts the src timestamp to a sample number, uses that internally, then reconverts the sample number to a timestamp for the output buffer.  Unfortunately, sample numbers can't be represented in an integer number of nanoseconds, and the conversion process was truncating rather than rounding, resulting in sample numbers and output timestamps that were often off by a full sample.

This corrects the time->sample convesion

ext/flac/gstflacdec.c

index 061fa81..1e2ef5e 100644 (file)
@@ -1668,7 +1668,7 @@ gst_flac_dec_convert_src (GstPad * pad, GstFormat src_format, gint64 src_value,
         case GST_FORMAT_BYTES:
           scale = bytes_per_sample;
         case GST_FORMAT_DEFAULT:
-          *dest_value = gst_util_uint64_scale_int (src_value,
+          *dest_value = gst_util_uint64_scale_int_round (src_value,
               scale * flacdec->sample_rate, GST_SECOND);
           break;
         default: