ASoC: soc-pcm: improve error messages in soc_pcm_new()
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 12 Jun 2020 20:40:49 +0000 (15:40 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 15 Jun 2020 16:12:10 +0000 (17:12 +0100)
Provide an explicit dmesg trace with the PCM 'new_name', dailink name
and error code to help with debug.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20200612204050.25901-3-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-pcm.c

index c517064..00aba7f 100644 (file)
@@ -2891,8 +2891,8 @@ int soc_new_pcm(struct snd_soc_pcm_runtime *rtd, int num)
                        capture, &pcm);
        }
        if (ret < 0) {
-               dev_err(rtd->card->dev, "ASoC: can't create pcm for %s\n",
-                       rtd->dai_link->name);
+               dev_err(rtd->card->dev, "ASoC: can't create pcm %s for dailink %s: %d\n",
+                       new_name, rtd->dai_link->name, ret);
                return ret;
        }
        dev_dbg(rtd->card->dev, "ASoC: registered pcm #%d %s\n",num, new_name);
@@ -2957,7 +2957,8 @@ int soc_new_pcm(struct snd_soc_pcm_runtime *rtd, int num)
 
        ret = snd_soc_pcm_component_new(rtd);
        if (ret < 0) {
-               dev_err(rtd->dev, "ASoC: pcm constructor failed: %d\n", ret);
+               dev_err(rtd->dev, "ASoC: pcm %s constructor failed for dailink %s: %d\n",
+                       new_name, rtd->dai_link->name, ret);
                return ret;
        }