Add a Function::isExternal utility to simplify checks for external functions.

PiperOrigin-RevId: 235746553

diff --git a/mlir/include/mlir/IR/Function.h b/mlir/include/mlir/IR/Function.h
index 3afb021c8ec4b9547039bbb69ca19d191e95ee76..2a4a88a919dbb03d542dc2f837327718628e9aca 100644 (file)
--- a/mlir/include/mlir/IR/Function.h
+++ b/mlir/include/mlir/IR/Function.h
@@ -80,6 +80,9 @@ public:
   /// Unlink this function from its module and delete it.
   void erase();
 
+  /// Returns true if this function is external, i.e. it has no body.
+  bool isExternal() const { return empty(); }
+
   //===--------------------------------------------------------------------===//
   // Body Handling
   //===--------------------------------------------------------------------===//

diff --git a/mlir/lib/Analysis/Verifier.cpp b/mlir/lib/Analysis/Verifier.cpp
index 45c760dbb1fb36e41eb995096b45bd37ff6d22ef..fbdf178769552629c8b1fd3d749d78e4508a4bd7 100644 (file)
--- a/mlir/lib/Analysis/Verifier.cpp
+++ b/mlir/lib/Analysis/Verifier.cpp
@@ -90,7 +90,7 @@ bool FuncVerifier::verify() {
                                    fn.getName().c_str());
 
   // External functions have nothing more to check.
-  if (fn.empty())
+  if (fn.isExternal())
     return false;
 
   // Verify the first block has no predecessors.

diff --git a/mlir/lib/IR/AsmPrinter.cpp b/mlir/lib/IR/AsmPrinter.cpp
index 9af1794cb0523752cb7728477a984738672309b0..3742367b8e7ef3bd863a7a12f4ca260df5816536 100644 (file)
--- a/mlir/lib/IR/AsmPrinter.cpp
+++ b/mlir/lib/IR/AsmPrinter.cpp
@@ -1301,7 +1301,7 @@ void FunctionPrinter::printFunctionSignature() {
   auto fnType = function->getType();
 
   // If this is an external function, don't print argument labels.
-  if (function->empty()) {
+  if (function->isExternal()) {
     interleaveComma(fnType.getInputs(),
                     [&](Type eltType) { printType(eltType); });
   } else {

diff --git a/mlir/lib/Pass/Pass.cpp b/mlir/lib/Pass/Pass.cpp
index 6a41cafcf1ee14c3d2fd008f48225be9efb95cb3..fddcb6e92aa77d3ce1965be21422e364f7d04342 100644 (file)
--- a/mlir/lib/Pass/Pass.cpp
+++ b/mlir/lib/Pass/Pass.cpp
@@ -37,7 +37,7 @@ void ModulePass::anchor() {}
 PassResult FunctionPass::runOnModule(Module *m) {
   for (auto &fn : *m) {
     // All function passes ignore external functions.
-    if (fn.empty())
+    if (fn.isExternal())
       continue;
 
     if (runOnFunction(&fn))

diff --git a/mlir/lib/Target/LLVMIR/ConvertToLLVMIR.cpp b/mlir/lib/Target/LLVMIR/ConvertToLLVMIR.cpp
index c5d611763d3662474728f1bf94cba519df1ca4ae..dfdf57ed64f13b21182650066ed2877316a6e17d 100644 (file)
--- a/mlir/lib/Target/LLVMIR/ConvertToLLVMIR.cpp
+++ b/mlir/lib/Target/LLVMIR/ConvertToLLVMIR.cpp
@@ -513,7 +513,7 @@ bool ModuleTranslation::convertFunctions() {
   // Convert functions.
   for (const Function &function : mlirModule) {
     // Ignore external functions.
-    if (function.empty())
+    if (function.isExternal())
       continue;
 
     if (convertOneFunction(function))