Input: elo - fix an error code in elo_connect()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 17 Feb 2021 04:29:05 +0000 (20:29 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Mar 2021 10:38:10 +0000 (11:38 +0100)
[ Upstream commit 0958351e93fa0ac142f6dd8bd844441594f30a57 ]

If elo_setup_10() fails then this should return an error code instead
of success.

Fixes: fae3006e4b42 ("Input: elo - add support for non-pressure-sensitive touchscreens")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YBKFd5CvDu+jVmfW@mwanda
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/input/touchscreen/elo.c

index e0bacd3..9617323 100644 (file)
@@ -341,8 +341,10 @@ static int elo_connect(struct serio *serio, struct serio_driver *drv)
        switch (elo->id) {
 
        case 0: /* 10-byte protocol */
-               if (elo_setup_10(elo))
+               if (elo_setup_10(elo)) {
+                       err = -EIO;
                        goto fail3;
+               }
 
                break;