i2c: efm32: Use devm_platform_get_and_ioremap_resource()
authorWang ShaoBo <bobo.shaobowang@huawei.com>
Fri, 18 Sep 2020 08:25:08 +0000 (16:25 +0800)
committerWolfram Sang <wsa@kernel.org>
Tue, 29 Sep 2020 19:37:46 +0000 (21:37 +0200)
Make use of devm_platform_get_and_ioremap_resource() provided by
driver core platform instead of duplicated analogue. dev_err() is
removed because it has been done in devm_ioremap_resource().

Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-efm32.c

index 838ce09..f6e13ce 100644 (file)
@@ -332,21 +332,15 @@ static int efm32_i2c_probe(struct platform_device *pdev)
                return ret;
        }
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!res) {
-               dev_err(&pdev->dev, "failed to determine base address\n");
-               return -ENODEV;
-       }
+       ddata->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
+       if (IS_ERR(ddata->base))
+               return PTR_ERR(ddata->base);
 
        if (resource_size(res) < 0x42) {
                dev_err(&pdev->dev, "memory resource too small\n");
                return -EINVAL;
        }
 
-       ddata->base = devm_ioremap_resource(&pdev->dev, res);
-       if (IS_ERR(ddata->base))
-               return PTR_ERR(ddata->base);
-
        ret = platform_get_irq(pdev, 0);
        if (ret <= 0) {
                if (!ret)