r300: Probably a good idea to always check the vertices; it's a WARN_ONCE so the
authorOliver McFadden <z3ro.geek@gmail.com>
Wed, 9 May 2007 22:06:19 +0000 (22:06 +0000)
committerOliver McFadden <z3ro.geek@gmail.com>
Wed, 9 May 2007 22:43:01 +0000 (22:43 +0000)
performance impact is extremely minimal.

src/mesa/drivers/dri/r300/r300_render.c

index fee2987..1ecddf6 100644 (file)
@@ -169,23 +169,22 @@ static int r300NumVerts(r300ContextPtr rmesa, int num_verts, int prim)
                fprintf(stderr,
                        "%s:%s Do not know how to handle primitive 0x%04x - help me !\n",
                        __FILE__, __FUNCTION__, prim & PRIM_MODE_MASK);
-               return -1;
+               return 0;
                break;
        }
 
-       if (RADEON_DEBUG & DEBUG_VERTS) {
-               if (num_verts - verts_off == 0) {
-                       WARN_ONCE
-                           ("user error: Need more than %d vertices to draw primitive 0x%04x !\n",
-                            num_verts, prim & PRIM_MODE_MASK);
-                       return 0;
-               }
+       if (num_verts - verts_off == 0) {
+               WARN_ONCE
+                   ("user error: Need more than %d vertices to draw primitive 0x%04x !\n",
+                    num_verts, prim & PRIM_MODE_MASK);
+               return 0;
+       }
 
-               if (verts_off > 0) {
-                       WARN_ONCE
-                           ("user error: %d is not a valid number of vertices for primitive 0x%04x !\n",
-                            num_verts, prim & PRIM_MODE_MASK);
-               }
+       if (verts_off > 0) {
+               WARN_ONCE
+                   ("user error: %d is not a valid number of vertices for primitive 0x%04x !\n",
+                    num_verts, prim & PRIM_MODE_MASK);
+               return 0;
        }
 
        return num_verts - verts_off;