arm64: dts: qcom: acer-aspire1: Correct audio codec definition
authorNikita Travkin <nikita@trvn.ru>
Tue, 5 Dec 2023 11:48:11 +0000 (16:48 +0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jan 2024 23:35:27 +0000 (15:35 -0800)
[ Upstream commit feec9f0add432a867f23e29afcd2f7088889b8e2 ]

When initially added, a mistake was made in the definition of the codec.

Despite the fact that the DMIC line is connected on the side of the
codec chip, and relevant passive components, including 0-ohm resistors
connecting the dmics, are present, the dmic line is still cut in
another place on the board, which was overlooked.

Correct this by replacing the dmic configuration with a comment
describing this hardware detail.

While at it, also add missing regulators definitions. This is not a
functional change as all the relevant regulators were already added via
the other rail supplies.

Fixes: 4a9f8f8f2ada ("arm64: dts: qcom: Add Acer Aspire 1")
Signed-off-by: Nikita Travkin <nikita@trvn.ru>
Link: https://lore.kernel.org/r/20231205-aspire1-sound-v2-2-443b7ac0a06f@trvn.ru
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts

index dbb4893..3342cb0 100644 (file)
                AVDD-supply = <&vreg_l15a_1p8>;
                MICVDD-supply = <&reg_codec_3p3>;
                VBAT-supply = <&reg_codec_3p3>;
+               DBVDD-supply = <&vreg_l15a_1p8>;
+               LDO1-IN-supply = <&vreg_l15a_1p8>;
+
+               /*
+                * NOTE: The board has a path from this codec to the
+                * DMIC microphones in the lid, however some of the option
+                * resistors are absent and the microphones are connected
+                * to the SoC instead.
+                *
+                * If the resistors were to be changed by the user to
+                * connect the codec, the following could be used:
+                *
+                * realtek,dmic1-data-pin = <1>;
+                * realtek,dmic1-clk-pin = <1>;
+                */
 
-               realtek,dmic1-data-pin = <1>;
-               realtek,dmic1-clk-pin = <1>;
                realtek,jd-src = <1>;
        };
 };