pwm: sprd: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 26 Aug 2020 14:47:46 +0000 (16:47 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 24 Sep 2020 07:18:11 +0000 (09:18 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-sprd.c

index be23942..5123d94 100644 (file)
@@ -228,11 +228,8 @@ static int sprd_pwm_clk_init(struct sprd_pwm_chip *spc)
                        if (ret == -ENOENT)
                                break;
 
-                       if (ret != -EPROBE_DEFER)
-                               dev_err(spc->dev,
-                                       "failed to get channel clocks\n");
-
-                       return ret;
+                       return dev_err_probe(spc->dev, ret,
+                                            "failed to get channel clocks\n");
                }
 
                clk_pwm = chn->clks[SPRD_PWM_CHN_OUTPUT_CLK].clk;