tty: hvc_iucv: Drop unnecessary NULL check after container_of
authorGuenter Roeck <linux@roeck-us.net>
Tue, 11 May 2021 01:25:19 +0000 (18:25 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 18:58:57 +0000 (20:58 +0200)
The result of container_of() operations is never NULL unless the extracted
element is the first element of the embedded structure. This is not the
case here. The NULL check is therefore unnecessary and misleading.
Remove it.

This change was made automatically with the following Coccinelle script.

@@
type t;
identifier v;
statement s;
@@

<+...
(
  t v = container_of(...);
|
  v = container_of(...);
)
  ...
  when != v
- if (\( !v \| v == NULL \) ) s
...+>

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20210511012519.2359074-1-linux@roeck-us.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/hvc/hvc_iucv.c

index 2af1e57..3bd03ae 100644 (file)
@@ -438,8 +438,6 @@ static void hvc_iucv_sndbuf_work(struct work_struct *work)
        struct hvc_iucv_private *priv;
 
        priv = container_of(work, struct hvc_iucv_private, sndbuf_work.work);
-       if (!priv)
-               return;
 
        spin_lock_bh(&priv->lock);
        hvc_iucv_send(priv);