DivergenceAnalysis: Fix crash with unreachable blocks
authorMatt Arsenault <Matthew.Arsenault@amd.com>
Fri, 29 Apr 2016 06:17:47 +0000 (06:17 +0000)
committerMatt Arsenault <Matthew.Arsenault@amd.com>
Fri, 29 Apr 2016 06:17:47 +0000 (06:17 +0000)
Unreachable blocks may not be in the dominator tree,
so don't crash on them.

llvm-svn: 268001

llvm/lib/Analysis/DivergenceAnalysis.cpp
llvm/test/Analysis/DivergenceAnalysis/AMDGPU/unreachable-loop-block.ll [new file with mode: 0644]

index b30539f..d38725f 100644 (file)
@@ -138,6 +138,11 @@ void DivergencePropagator::exploreSyncDependency(TerminatorInst *TI) {
   //   a2 = 2;
   // a = phi(a1, a2); // sync dependent on (tid < 5)
   BasicBlock *ThisBB = TI->getParent();
+
+  // Unreachable blocks may not be in the dominator tree.
+  if (!DT.isReachableFromEntry(ThisBB))
+    return;
+
   BasicBlock *IPostDom = PDT.getNode(ThisBB)->getIDom()->getBlock();
   if (IPostDom == nullptr)
     return;
diff --git a/llvm/test/Analysis/DivergenceAnalysis/AMDGPU/unreachable-loop-block.ll b/llvm/test/Analysis/DivergenceAnalysis/AMDGPU/unreachable-loop-block.ll
new file mode 100644 (file)
index 0000000..ca93dda
--- /dev/null
@@ -0,0 +1,17 @@
+; RUN: opt %s -mtriple amdgcn-- -analyze -divergence | FileCheck %s
+
+; CHECK: DIVERGENT:  %tmp = cmpxchg volatile
+define void @unreachable_loop(i32 %tidx) #0 {
+entry:
+  unreachable
+
+unreachable_loop:                                        ; preds = %do.body.i, %if.then11
+  %tmp = cmpxchg volatile i32 addrspace(1)* null, i32 0, i32 0 seq_cst seq_cst
+  %cmp.i = extractvalue { i32, i1 } %tmp, 1
+  br i1 %cmp.i, label %unreachable_loop, label %end
+
+end:                                      ; preds = %do.body.i51, %atomicAdd_g_f.exit
+  unreachable
+}
+
+attributes #0 = { norecurse nounwind }