pinctrl: stm32: Switch to use dev_err_probe() helper
authorYang Yingliang <yangyingliang@huawei.com>
Sat, 17 Sep 2022 12:20:15 +0000 (20:20 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 20 Sep 2022 09:16:42 +0000 (11:16 +0200)
In the probe path, dev_err() can be replace with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220917122015.1893880-1-yangyingliang@huawei.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/stm32/pinctrl-stm32.c

index 14bcca7..e485506 100644 (file)
@@ -1603,10 +1603,9 @@ int stm32_pctl_probe(struct platform_device *pdev)
 
                bank->clk = of_clk_get_by_name(np, NULL);
                if (IS_ERR(bank->clk)) {
-                       if (PTR_ERR(bank->clk) != -EPROBE_DEFER)
-                               dev_err(dev, "failed to get clk (%ld)\n", PTR_ERR(bank->clk));
                        fwnode_handle_put(child);
-                       return PTR_ERR(bank->clk);
+                       return dev_err_probe(dev, PTR_ERR(bank->clk),
+                                            "failed to get clk\n");
                }
                i++;
        }