ext4: remove redundant checking in ext4_ioctl_checkpoint
authorGuoqing Jiang <guoqing.jiang@linux.dev>
Sun, 18 Sep 2022 11:52:19 +0000 (19:52 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 1 Oct 2022 03:46:54 +0000 (23:46 -0400)
It is already checked after comment "check for invalid bits set",
so let's remove this one.

Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
Link: https://lore.kernel.org/r/20220918115219.12407-1-guoqing.jiang@linux.dev
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/ioctl.c

index ad3a294..4d49c5c 100644 (file)
@@ -1063,9 +1063,6 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg)
        if (!EXT4_SB(sb)->s_journal)
                return -ENODEV;
 
-       if (flags & ~EXT4_IOC_CHECKPOINT_FLAG_VALID)
-               return -EINVAL;
-
        if ((flags & JBD2_JOURNAL_FLUSH_DISCARD) &&
            !bdev_max_discard_sectors(EXT4_SB(sb)->s_journal->j_dev))
                return -EOPNOTSUPP;