ecore - proc env - fix values return NULL case - coverity

this fixes CID 1419857

diff --git a/src/lib/ecore/efl_core_proc_env.c b/src/lib/ecore/efl_core_proc_env.c
index 4e7c934..1bbec68 100644 (file)
--- a/src/lib/ecore/efl_core_proc_env.c
+++ b/src/lib/ecore/efl_core_proc_env.c
@@ -58,7 +58,11 @@ _sync(Efl_Core_Env *obj, Efl_Core_Proc_Env_Data *pd)
              char **values;
 
              values = eina_str_split(*p, "=", 2);
-             if (values)
+             if (!values) break;
+
+             efl_core_env_set(obj, values[0], values[1]);
+
+             EINA_LIST_FOREACH(existing_keys, n, key)
                {
                   efl_core_env_set(obj, values[0], values[1]);
 
@@ -70,9 +74,9 @@ _sync(Efl_Core_Env *obj, Efl_Core_Proc_Env_Data *pd)
                             break;
                          }
                     }
-                  free(values[0]);
-                  free(values);
                }
+             free(values[0]);
+             free(values);
           }
      }
    EINA_LIST_FOREACH(existing_keys, n, key)