internal static string TryExpandShortFileName(ref ValueStringBuilder outputBuilder, string? originalPath)
{
// We guarantee we'll expand short names for paths that only partially exist. As such, we need to find the part of the path that actually does exist. To
- // avoid allocating like crazy we'll create only one input array and modify the contents with embedded nulls.
+ // avoid allocating a lot we'll create only one input array and modify the contents with embedded nulls.
Debug.Assert(!PathInternal.IsPartiallyQualified(outputBuilder.AsSpan()), "should have resolved by now");
// If we have more than 128 variables, we can't just set the length, we need
// to compress it. Unfortunately, this means that we need to copy the entire
- // array. Bummer, eh?
+ // array.
SetNumberOfSignatureElements(false);
}
### What’s checked in - suboptimal
For MQ, SOS activates mscordbi.dll via the “typical” mechanism of calling into mscoree.dll to get the ICLRDebugging interface, on which SOS calls OpenVirtualProcess.
-Although this works, it sucks.
+Although this works, it is not ideal.
It assumes the CLR you want to debug has been formally installed onto the debugging machine (complete with mscoree.dll in your system32 / syswow64 directory).
### Recommendation
LOG((LF_CORDB, LL_INFO1000, "CP::TE1stCAI: Enter\n"));
#ifdef _DEBUG
- // Some Interop bugs involve threads that land at a crazy IP. Since we're interop-debugging, we can't
+ // Some Interop bugs involve threads that land at a bad IP. Since we're interop-debugging, we can't
// attach a debugger to the LS. So we have some debug mode where we enable the SS flag and thus
// produce a trace of where a thread is going.
if (pUnmanagedThread->IsDEBUGTrace() && (dwExCode == STATUS_SINGLE_STEP))
STRESS_LOG1(LF_CORDB, LL_INFO1000, "W32ET::W32EL: Thread 0x%x is suspended\n", pEvent->dwThreadId);
}
- // For debugging crazy races in retail, we'll keep a rolling queue of win32 debug events.
+ // For debugging races in retail, we'll keep a rolling queue of win32 debug events.
this->DebugRecordWin32Event(pEvent, pUnmanagedThread);
}
-// Some Interop bugs involve threads that land at a crazy IP. Since we're interop-debugging, we can't
+// Some Interop bugs involve threads that land at a bad IP. Since we're interop-debugging, we can't
// attach a debugger to the LS. So we have some debug mode where we enable the SS flag and thus
// produce a trace of where a thread is going.
#ifdef _DEBUG
// We're not going to be called for a unmanaged exception.
// Should always have a managed thread, but just in case something really
- // crazy happens, it's not worth an AV. (since this is just being used as a hint)
+ // strange happens, it's not worth an AV. (since this is just being used as a hint)
if (pThread == NULL)
{
return false;
HRESULT hr = pModule->GetMDImport()->GetParentToken(token, &classToken);
if (FAILED(hr))
{
- // We never expect this to actually fail, but just in case it does for some other crazy reason,
+ // We never expect this to actually fail, but just in case it does for some other strange reason,
// we'll return before we AV.
CONSISTENCY_CHECK_MSGF(false, ("Class lookup failed:mdToken:0x%08x, pModule=%p. hr=0x%08x\n", token, pModule, hr));
return hr;
// returns true if we the eightbyte at index slotIndex is of SSE type.
//
// Follows the rules of the AMD64 System V ABI specification at www.x86-64.org/documentation/abi.pdf.
- // Please reffer to it for definitions/examples.
+ // Please refer to it for definitions/examples.
//
bool IsSseSlot(unsigned slotIndex) const
{
// WARNING: The MBCS version of printf function are factory for globalization
// issues when used to format Unicode strings (%S). The Unicode versions are
- // preffered in this case.
+ // preferred in this case.
void Printf(const CHAR *format, ...);
void VPrintf(const CHAR *format, va_list args);
}
// We can get to this point for blocks that we didn't create as throw helper blocks
- // under stress, with crazy flow graph optimizations. So, walk the fgAddCodeList
+ // under stress, with implausible flow graph optimizations. So, walk the fgAddCodeList
// for the final determination.
for (AddCodeDsc* add = fgAddCodeList; add; add = add->acdNext)
assert(m_ranges == nullptr);
assert(m_lastRange == 0);
- // Flag any crazy-looking requests
+ // Flag any strange-looking requests
assert(capacity < 100000);
if (rangeStr == nullptr)
HRESULT hr = m_peSectionMan->getSectionCreate(name, flags, &pewSect);
TESTANDRETURNHR(hr);
CeeSection *newSect = new CeeSection(*this, *pewSect);
- // if this fails, the PESection will get nuked in the destructor for CCeeGen
+ // if this fails, the PESection will get zapped in the destructor for CCeeGen
if (newSect == NULL)
{
return E_OUTOFMEMORY;
#ifndef __STRINGTEST_H__
#define __STRINGTEST_H__
-/* These functions leaks memory like crazy. C'est la vie. */
+/* These functions leaks memory a lot. C'est la vie. */
int Testvsnprintf(char* buf, size_t count, const char* format, ...)
{
int retVal;
#ifndef ___VSNWPRINTF_H__
#define ___VSNWPRINTF_H__
-/* These functions leaks memory like crazy. C'est la vie. */
+/* These functions leaks memory a lot. C'est la vie. */
int TestVsnwprintf_s(wchar_t* buf, size_t count, const wchar_t* format, ...)
{
int retVal = 0;
#ifndef __VSPRINTF_H__
#define __VSPRINTF_H__
-/* These functions leaks memory like crazy. C'est la vie. */
+/* These functions leaks memory a lot. C'est la vie. */
int testvsp(char* buf, size_t buffSize, const char* format, ...)
{
int retVal;
#ifndef __vswprintf_H__
#define __vswprintf_H__
-/* These functions leaks memory like crazy. C'est la vie. */
+/* These functions leaks memory a lot. C'est la vie. */
int testvswp(wchar_t* buf, size_t buffSize, const wchar_t* format, ...)
{
int retVal = 0;
{
// Skip the backslash when copying
// Note: We don't support strings longer than 4GB, but that's
- // okay because we already barf at MAX_PATH
+ // okay because we already fail at MAX_PATH
int iRemaining = (int)(ARRAYSIZE(szTemp) - (pszT - szTemp));
StringCchCopyNW(pszT, iRemaining, lpszFile+1, iRemaining);
}
}
//
-// Is pModule likely a dependency of pOtherModule? Heuristic used by preffered zap module algorithm.
+// Is pModule likely a dependency of pOtherModule? Heuristic used by preferred zap module algorithm.
// It can return both false positives and negatives.
//
static bool IsLikelyDependencyOf(Module * pModule, Module * pOtherModule)
//
// - Can be called with gc enabled or disabled.
// This allows a catch-all error path to post a generic catchall error
-// message w/out bonking more specific error messages posted by inner functions.
+// message w/out overwriting more specific error messages posted by inner functions.
//==========================================================================
VOID DECLSPEC_NORETURN ThrowTypeLoadException(LPCWSTR pFullTypeName,
LPCWSTR pAssemblyName,
//
// - Can be called with gc enabled or disabled.
// This allows a catch-all error path to post a generic catchall error
-// message w/out bonking more specific error messages posted by inner functions.
+// message w/out overwriting more specific error messages posted by inner functions.
//==========================================================================
VOID DECLSPEC_NORETURN ThrowTypeLoadException(LPCUTF8 pszNameSpace,
LPCUTF8 pTypeName,
//
// - Can be called with gc enabled or disabled.
// This allows a catch-all error path to post a generic catchall error
-// message w/out bonking more specific error messages posted by inner functions.
+// message w/out overwriting more specific error messages posted by inner functions.
//==========================================================================
VOID DECLSPEC_NORETURN ThrowTypeLoadException(LPCUTF8 pNameSpace, LPCUTF8 pTypeName,
LPCWSTR pAssemblyName, LPCUTF8 pMessageArg,
// by shifting and gaining a free high-bit.
ULONG encodedDelta = delta >> 1;
#else
- // For 32-bit, we just limit our frame size to <2GB. (I know, such a bummer!)
+ // For 32-bit, we just limit our frame size to <2GB.
ULONG encodedDelta = delta;
#endif
_ASSERTE((encodedDelta & 0x80000003) == 0);
// We temporarily disable IBC logging here
// because the pMD that we search through may not be restored
- // and ComputePrefferedZapModule will assert on finding an
+ // and ComputePreferredZapModule will assert on finding an
// encode fixup pointer
//
IBCLoggingDisabler disableIbcLogging;
// "security feature". It's mainly useful as defense-in-depth or to protect
// IE users and admins from themselves in most cases.
// * It's impossible to spawn a system integrity trigger process outside of
- // session 0 services. So profiling ASP.NET would be crazy hard without this
+ // session 0 services. So profiling ASP.NET would be really hard without this
// policy.
DWORD * pdwIntegrityLevel = SecurityUtil::GetIntegrityLevelFromMandatorySID(ptml->Label.Sid);
if (*pdwIntegrityLevel > SECURITY_MANDATORY_HIGH_RID)
HRESULT hr;
- // Is cbClientData just crazy-sick-overflow big?
+ // Is cbClientData just huge?
if (cbClientData >= 0xFFFFffffUL - sizeof(AttachRequestMessage))
{
return E_OUTOFMEMORY;
SyncTableEntry::GetSyncTableEntry() [indx].m_SyncBlock = syncBlock;
- // in order to avoid a race where some thread tries to get the AD index and we've already nuked it,
+ // in order to avoid a race where some thread tries to get the AD index and we've already zapped it,
// make sure the syncblock etc is all setup with the AD index prior to replacing the index
// in the header
if (GetHeaderSyncBlockIndex() == 0)
}
EX_CATCH
{
- // Bummer... couldn't init the abort event. Its a shame, but not fatal. We'll simply not use it
+ // Couldn't init the abort event. Its a shame, but not fatal. We'll simply not use it
// on this iteration and try again next time.
if (pEvent) {
_ASSERTE(!pEvent->IsValid());
projects / platform / upstream / coreclr.git / commitdiff