Removes null pointer exceptions.
Change-Id: I39f2b5173f7e77a4fe1c42ca45b8158bfeb072e4
Signed-off-by: nakyoung2.choi <nakyoung2.choi@samsung.com>
/**
* The error string.
*/
- private static final String ERROR = "error"; //$NON-NLS-1$
+ public static final String ERROR = "error"; //$NON-NLS-1$
/**
* An auto size.
fullValue = value + unit;
}
} else {
- fullValue = value + BuilderConstants.OPEN_BRACKET;
+ StringBuilder builder = new StringBuilder(value);
+ builder.append(BuilderConstants.OPEN_BRACKET);
int paramSize = parameters.size();
for (int i = 0; i < paramSize; i++) {
CssComponent child = parameters.get(i);
- fullValue += child.getValue();
+ builder.append(child.getValue());
if (i + 1 != paramSize) {
- fullValue += BuilderConstants.COMMA + BuilderConstants.SPACE;
+ builder.append(BuilderConstants.COMMA);
+ builder.append(BuilderConstants.SPACE);
}
-
}
- fullValue += BuilderConstants.CLOSE_BRACKET;
+ builder.append(BuilderConstants.CLOSE_BRACKET);
+ fullValue = builder.toString();
}
return fullValue;
}
if (value != null) {
return value;
}
- String temp = BuilderConstants.EMPTY;
+ StringBuilder builder = new StringBuilder();
Iterator<CssComponent> iter = components.iterator();
while (iter.hasNext()) {
- temp += iter.next().getValue();
+ builder.append(iter.next().getValue());
if (iter.hasNext()) {
- temp += BuilderConstants.SPACE;
+ builder.append(BuilderConstants.SPACE);
}
}
- value = temp;
+ value = builder.toString();
return value;
}
static List<CssComponent> metrixToComponent(List<CssComponent> list, LexicalUnit lu,
CssPropertyDescriptor propDescriptor) {
+ if (propDescriptor == null) {
+ return null;
+ }
// List<CssComponent> componentList= new ArrayList<CssComponent>();
List<CssComponent> componentList = list;
private static CssComponent createTransformComponent(CssComponent parent, double matrixValue[],
CssPropertyDescriptor propDescriptor) {
+ if (propDescriptor == null) {
+ return null;
+ }
String getPropertyName = propDescriptor.getPropertyName();
int childDescriptorSize = propDescriptor.getChildPropertyDescriptors().size();
}
Part part = rootPart.getChildOfIdPropertyValue(partId, true);
+ if (part == null) {
+ return BuilderConstants.EMPTY;
+ }
String css = getCssCode(part, false);
return css;
CssSelector selector = getCurrentCssFile()
.getSelector(selectorName);
if (selector == null
- && !part.getPositionMode().equals(
+ || !part.getPositionMode().equals(
Part.PositionMode.ABSOLUTE_POSITION)) {
return;
} else if (selector != null) {
public Command getCommand(Request req) {
if (OutlineConstants.REQ_RENAME.equals(req.getType())) {
return getRenameCommand(req);
- }
- if (REQ_MOVE.equals(req.getType())) {
- return getMoveCommand((ChangeBoundsRequest) req);
+ } else if (REQ_MOVE.equals(req.getType())) {
+ if (req instanceof ChangeBoundsRequest) {
+ return getMoveCommand((ChangeBoundsRequest) req);
+ }
}
return super.getCommand(req);
}
/* load css file */
if (pageData != null && pageData.getCssFiles() != null
- && pageData.getCssFiles().size() == 0) {
+ && pageData.getCssFiles().size() == 0 && pageFileData != null) {
for (NScreenModel model : pageFileData.getNscreenModelList()) {
CssFile cssFile = null;
if (model.getFileName() == null
ErrorDialog.open("Couldn't open HTML editor");
}
+ if (htmlEditor == null) {
+ return;
+ }
StructuredTextEditor editor = null;
if (htmlEditor instanceof StructuredTextEditor) {
editor = (StructuredTextEditor) htmlEditor;
private Composite parentComposite;
private Part model;
private CommandStack commandStack;
- private Composite clientComposite;
+// private Composite clientComposite;
private List<ActionCustomEventComposite> actionSelectionBars =
new ArrayList<ActionCustomEventComposite>();
private static String displayLabel = "Custom Actions";
- private int triggerCount = 0;
+// private int triggerCount = 0;
public ActionCustomActionAdderComposite(Composite parent, int style, Part model,
CommandStack commandStack) {
private void init() {
- clientComposite = this;
- Composite customLabelComposite = createClientForEventName(this, SWT.NONE, displayLabel);
+// clientComposite = this;
+// Composite customLabelComposite = createClientForEventName(this, SWT.NONE, displayLabel);
+ createClientForEventName(this, SWT.NONE, displayLabel);
return;
}
private FormToolkit toolkit;
private Part model;
private CommandStack commandStack;
- private Composite eventNameComposite;
+// private Composite eventNameComposite;
private Composite clientComposite;
private int actionBarIndex = 0;
private List<ActionSelectBarComposite> actionSelectionBars =
*/
private void init() {
- eventNameComposite = createClientForEventName(this, SWT.NONE, triggerDisplayName);
+// eventNameComposite = createClientForEventName(this, SWT.NONE, triggerDisplayName);
+ createClientForEventName(this, SWT.NONE, triggerDisplayName);
clientComposite = this;
return;
import org.eclipse.ui.forms.events.IExpansionListener;
import org.eclipse.ui.forms.widgets.ExpandableComposite;
import org.eclipse.ui.forms.widgets.FormToolkit;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import org.tizen.webuibuilder.animator.gef.command.ActoinCreateCommand;
import org.tizen.webuibuilder.animator.model.AnimatorAction;
import org.tizen.webuibuilder.animator.model.AnimatorAnimation;
// lastUpperComposite = addAnimationEC(clientComposite, SWT.BORDER,
// predefinedAnimatorAction);
// }
+ Logger logger = LoggerFactory.getLogger(getClass());
+ logger.debug("modelTrigger is " + modelTrigger.getEventName());
}
private List<ActionEventComposite> actionEventComposites =
new ArrayList<ActionEventComposite>();
private ActionCustomActionAdderComposite customActionAdder;
- private Method messageMethod;
+// private Method messageMethod;
private CommandStack commandStack;
private Method noContent;
customActionAdder.dispose();
}
- if (messageMethod != null) {
- messageMethod.dispose();
- }
+// if (messageMethod != null) {
+// messageMethod.dispose();
+// }
}
*/
public class AttributesEventDelegater implements IPartListener, IValueChangeListener, ICssListener {
- @SuppressWarnings("unused")
- private List<Part> models;
+// @SuppressWarnings("unused")
+
// private List<Part> models;
private Part model;
private CommandStack commandStack;
private AttributesTab attrTab;
* list of {@link Part}
*/
public void setModel(List<Part> models) {
- this.models = models;
+// this.models = models;
if (models != null && !models.isEmpty()) {
model = models.get(0);
String comparePropName = condition.getValue();
Method compareMethod = attrTab.getMethod(comparePropName);
+ if (compareMethod == null) {
+ return WidgetValidator.ERROR;
+ }
message =
model.canSetPropertyValue(condition, newValue,
compareMethod.getValue(),
import org.eclipse.swt.widgets.Label;
import org.eclipse.swt.widgets.Listener;
import org.eclipse.swt.widgets.Text;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import org.tizen.webuibuilder.BuilderConstants;
import org.tizen.webuibuilder.model.Part;
import org.tizen.webuibuilder.utility.ResourceManager;
}
} else if (value.toLowerCase().contains("auto")) {
// do nothing !!
+ Logger logger = LoggerFactory.getLogger(getClass());
+ logger.debug("Do nothing on setViewData");
}
}
}
String text = userView.getText();
switch (checkValidation(text)) {
case HEX:
- if (check.getSelection())
+ if (check.getSelection()) {
target.setValue(text);
+ }
break;
case RGBA:
case RGB:
- if (check.getSelection())
- target.setValue(changeRgbString2HexString(text));
+ if (check.getSelection()) {
+ String value = changeRgbString2HexString(text);
+ if (value == null) {
+ value = BuilderConstants.EMPTY;
+ }
+ target.setValue(value);
+ }
+
break;
case NONE:
default:
@Override
protected FormData getControlLayoutData() {
- FormData data = new FormData();
+ FormData data = super.getControlLayoutData();
data.top = new FormAttachment(getLabel(), 0, SWT.CENTER);
data.left = new FormAttachment(getLabel(), 0);
data.right = new FormAttachment(100, -30);
@Override
public void refreshValue(String name, String value) {
+ super.refreshValue(name, value);
getControl().setText(value);
}
break;
case RGBA:
case RGB:
- target.setValue(changeRgbString2HexString(text));
+ String value = changeRgbString2HexString(text);
+ if (value == null) {
+ value = BuilderConstants.EMPTY;
+ }
+ target.setValue(value);
break;
case NONE:
default:
resetChilden();
return;
}
+ if (name == null) {
+ name = BuilderConstants.EMPTY;
+ }
Method child = getChildMethod(name);
if (child != null) {
import org.eclipse.gef.commands.Command;
import org.eclipse.gef.commands.CommandStack;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import org.tizen.webuibuilder.BuilderConstants;
import org.tizen.webuibuilder.animator.gef.command.SetCssStyleAnimationPropertyCommand;
import org.tizen.webuibuilder.animator.model.AnimatorFrame;
CssCategoryDescriptor descriptor = cssStyleTab.getFakeDescriptor(null);
+ if (descriptor == null) {
+ Logger logger = LoggerFactory.getLogger(getClass());
+ logger.error("Descriptor is null");
+ return;
+ }
descriptorDefaultSetter(descriptor);
for (CssPropertyDescriptor property : descriptor.getCssPropertyDescriptors()) {
* target descriptor for set default value {@link CssCategoryDescriptor}
*/
private void descriptorDefaultSetter(CssCategoryDescriptor descriptor) {
+ if (descriptor == null) {
+ return;
+ }
CssSelector selector = cssStyleTab.getCssSelector();
String value = selector.getPropertyValue("-webkit-transform");
if (value == null || value.equals(BuilderConstants.EMPTY)) {
if (categoryContainer == null || categoryContainer.isDisposed()) {
logger.error("Category Conatainer disposed...");
+ return;
}
GridData categoryData = (GridData) categoryContainer.getLayoutData();
/* 1. check already been frame */
AnimatorSelector animatorSelector = getAnimatorSelector();
+ if (animatorSelector == null) {
+ return null;
+ }
tempFrame = animatorSelector.getAnimatorFrameByCurrentTime(currentTime);
/* 2. create frame if not be */
tempFrame = getFrame();
}
} else {
+ Logger logger = LoggerFactory.getLogger(getClass());
+ logger.error("CssStyleTab has not animator model");
// TODO Log("has not model");
}
return tempFrame;
projects / sdk / ide / web-ui-builder-eplugin.git / commitdiff