staging: most: cdev: fix return values
authorChristian Gromm <christian.gromm@microchip.com>
Mon, 22 Jun 2020 08:48:14 +0000 (10:48 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jun 2020 13:40:28 +0000 (15:40 +0200)
This patch makes use of the proper return values when reporting
an error to the caller.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Link: https://lore.kernel.org/r/1592815695-19305-6-git-send-email-christian.gromm@microchip.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/most/cdev/cdev.c

index d374cc0..aa7d7af 100644 (file)
@@ -326,7 +326,7 @@ static int comp_disconnect_channel(struct most_interface *iface, int channel_id)
 
        c = get_channel(iface, channel_id);
        if (!c)
-               return -ENXIO;
+               return -EINVAL;
 
        mutex_lock(&c->io_mutex);
        spin_lock(&c->unlink);
@@ -360,7 +360,7 @@ static int comp_rx_completion(struct mbo *mbo)
 
        c = get_channel(mbo->ifp, mbo->hdm_channel_id);
        if (!c)
-               return -ENXIO;
+               return -EINVAL;
 
        spin_lock(&c->unlink);
        if (!c->access_ref || !c->dev) {
@@ -390,7 +390,7 @@ static int comp_tx_completion(struct most_interface *iface, int channel_id)
 
        c = get_channel(iface, channel_id);
        if (!c)
-               return -ENXIO;
+               return -EINVAL;
 
        if ((channel_id < 0) || (channel_id >= iface->num_channels)) {
                dev_warn(c->dev, "Channel ID out of range\n");