mtd: rawnand: gpmi: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Tue, 1 Sep 2020 14:25:32 +0000 (16:25 +0200)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Wed, 30 Sep 2020 14:44:17 +0000 (16:44 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200901142535.12819-3-krzk@kernel.org
drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c

index 86dc83d..dc8104e 100644 (file)
@@ -1004,10 +1004,8 @@ static int acquire_dma_channels(struct gpmi_nand_data *this)
        /* request dma channel */
        dma_chan = dma_request_chan(&pdev->dev, "rx-tx");
        if (IS_ERR(dma_chan)) {
-               ret = PTR_ERR(dma_chan);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(this->dev, "DMA channel request failed: %d\n",
-                               ret);
+               ret = dev_err_probe(this->dev, PTR_ERR(dma_chan),
+                                   "DMA channel request failed\n");
                release_dma_channels(this);
        } else {
                this->dma_chans[0] = dma_chan;