mmc: tmio: deprecate "toshiba, mmc-wrprotect-disable" DT property
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Wed, 17 Jan 2018 16:28:11 +0000 (01:28 +0900)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 5 Mar 2018 08:09:11 +0000 (09:09 +0100)
This property is equivalent to "disable-wp" defined in
Documentation/devicetree/bindings/mmc/mmc.txt

The TMIO MMC core calls mmc_of_parse(), and it sets
MMC_CAP2_NO_WRITE_PROTECT if "disable-wp" property is present.

We do not need a vendor-specific property to do the same thing.

Let's remove the description from the dt-binding to prevent new boards
from using it.

I am keeping the driver code for existing DT files, but added
comments that this is deprecated.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Documentation/devicetree/bindings/mmc/tmio_mmc.txt
drivers/mmc/host/tmio_mmc_core.c

index d8685cb..2d5287e 100644 (file)
@@ -50,7 +50,6 @@ Required properties:
          2: R7S72100
 
 Optional properties:
-- toshiba,mmc-wrprotect-disable: write-protect detection is unavailable
 - pinctrl-names: should be "default", "state_uhs"
 - pinctrl-0: should contain default/high speed pin ctrl
 - pinctrl-1: should contain uhs mode pin ctrl
index fb5a29c..f5da8bb 100644 (file)
@@ -1120,6 +1120,11 @@ static void tmio_mmc_of_parse(struct platform_device *pdev,
        if (!np)
                return;
 
+       /*
+        * DEPRECATED:
+        * For new platforms, please use "disable-wp" instead of
+        * "toshiba,mmc-wrprotect-disable"
+        */
        if (of_get_property(np, "toshiba,mmc-wrprotect-disable", NULL))
                mmc->caps2 |= MMC_CAP2_NO_WRITE_PROTECT;
 }