net: arcnet: Do not call kfree_skb() under local_irq_disable()
authorJinjie Ruan <ruanjinjie@huawei.com>
Thu, 24 Aug 2023 06:43:36 +0000 (14:43 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 25 Aug 2023 09:10:52 +0000 (10:10 +0100)
It is not allowed to call kfree_skb() from hardware interrupt
context or with hardware interrupts being disabled.
So replace kfree_skb() with dev_kfree_skb_irq() under
local_irq_disable(). Compile tested only.

Fixes: 05fcd31cc472 ("arcnet: add err_skb package for package status feedback")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/arcnet/arcnet.c

index 9926566..d9e052c 100644 (file)
@@ -464,7 +464,7 @@ static void arcnet_reply_tasklet(struct tasklet_struct *t)
 
        ret = sock_queue_err_skb(sk, ackskb);
        if (ret)
-               kfree_skb(ackskb);
+               dev_kfree_skb_irq(ackskb);
 
        local_irq_enable();
 };