bpf: Fix tcp_synrto_kern.c sample program
authorLawrence Brakmo <brakmo@fb.com>
Sat, 11 Nov 2017 06:19:50 +0000 (22:19 -0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 11 Nov 2017 06:52:41 +0000 (15:52 +0900)
The program was returning -1 in some cases which is not allowed
by the verifier any longer.

Fixes: 390ee7e29fc8 ("bpf: enforce return code for cgroup-bpf programs")
Signed-off-by: Lawrence Brakmo <brakmo@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
samples/bpf/tcp_synrto_kern.c

index 3c3fc83d81cb80f2a2e0879f90cbb91f29302ab6..232bb242823eb6fddaeb2f7c3d6ba26a9432011c 100644 (file)
@@ -38,8 +38,10 @@ int bpf_synrto(struct bpf_sock_ops *skops)
         * if neither port numberis 55601
         */
        if (bpf_ntohl(skops->remote_port) != 55601 &&
-           skops->local_port != 55601)
-               return -1;
+           skops->local_port != 55601) {
+               skops->reply = -1;
+               return 1;
+       }
 
        op = (int) skops->op;