net: wireless: remove unnecessary platform_set_drvdata()
authorJingoo Han <jg1.han@samsung.com>
Mon, 27 May 2013 19:07:11 +0000 (19:07 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 28 May 2013 05:34:52 +0000 (22:34 -0700)
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wireless/ath/ath5k/ahb.c
drivers/net/wireless/ath/ath9k/ahb.c

index 8e8bcc7..e9bc9e6 100644 (file)
@@ -185,7 +185,6 @@ static int ath_ahb_probe(struct platform_device *pdev)
 
  err_free_hw:
        ieee80211_free_hw(hw);
-       platform_set_drvdata(pdev, NULL);
  err_iounmap:
         iounmap(mem);
  err_out:
@@ -221,7 +220,6 @@ static int ath_ahb_remove(struct platform_device *pdev)
 
        ath5k_deinit_ah(ah);
        iounmap(ah->iobase);
-       platform_set_drvdata(pdev, NULL);
        ieee80211_free_hw(hw);
 
        return 0;
index d1ff3c2..072e4b5 100644 (file)
@@ -150,7 +150,6 @@ static int ath_ahb_probe(struct platform_device *pdev)
        free_irq(irq, sc);
  err_free_hw:
        ieee80211_free_hw(hw);
-       platform_set_drvdata(pdev, NULL);
        return ret;
 }
 
@@ -164,7 +163,6 @@ static int ath_ahb_remove(struct platform_device *pdev)
                ath9k_deinit_device(sc);
                free_irq(sc->irq, sc);
                ieee80211_free_hw(sc->hw);
-               platform_set_drvdata(pdev, NULL);
        }
 
        return 0;