netfilter: nft_meta: fix iifgroup matching
authorFlorian Westphal <fw@strlen.de>
Sun, 2 Aug 2020 01:27:03 +0000 (03:27 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Sun, 2 Aug 2020 02:10:20 +0000 (04:10 +0200)
iifgroup matching erroneously checks the output interface.

Fixes: 8724e819cc9a ("netfilter: nft_meta: move all interface related keys to helper")
Reported-by: Demi M. Obenour <demiobenour@gmail.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nft_meta.c

index 951b6e8..7bc6537 100644 (file)
@@ -253,7 +253,7 @@ static bool nft_meta_get_eval_ifname(enum nft_meta_keys key, u32 *dest,
                        return false;
                break;
        case NFT_META_IIFGROUP:
-               if (!nft_meta_store_ifgroup(dest, nft_out(pkt)))
+               if (!nft_meta_store_ifgroup(dest, nft_in(pkt)))
                        return false;
                break;
        case NFT_META_OIFGROUP: