drivers/net/ibmvnic: Update VNIC protocol version reporting
authorThomas Falcon <tlfalcon@linux.ibm.com>
Thu, 28 May 2020 16:19:17 +0000 (11:19 -0500)
committerDavid S. Miller <davem@davemloft.net>
Sat, 30 May 2020 00:20:59 +0000 (17:20 -0700)
VNIC protocol version is reported in big-endian format, but it
is not byteswapped before logging. Fix that, and remove version
comparison as only one protocol version exists at this time.

Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ibm/ibmvnic.c

index 3de549c..197dc5b 100644 (file)
@@ -4678,12 +4678,10 @@ static void ibmvnic_handle_crq(union ibmvnic_crq *crq,
                        dev_err(dev, "Error %ld in VERSION_EXCHG_RSP\n", rc);
                        break;
                }
-               dev_info(dev, "Partner protocol version is %d\n",
-                        crq->version_exchange_rsp.version);
-               if (be16_to_cpu(crq->version_exchange_rsp.version) <
-                   ibmvnic_version)
-                       ibmvnic_version =
+               ibmvnic_version =
                            be16_to_cpu(crq->version_exchange_rsp.version);
+               dev_info(dev, "Partner protocol version is %d\n",
+                        ibmvnic_version);
                send_cap_queries(adapter);
                break;
        case QUERY_CAPABILITY_RSP: