base/node: Use 'property' to identify an access parameter
authorDave Jiang <dave.jiang@intel.com>
Fri, 5 May 2023 21:28:55 +0000 (14:28 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 31 May 2023 19:26:00 +0000 (20:26 +0100)
Usage of 'attr' and 'name' in the context of a sysfs attribute
definition are confusing because those read as being related to:

struct attribute .name

Rename 'name' to 'property' in preparation for renaming 'struct
node_hmem_attr' to a more generic name that can be used in more contexts
('struct access_coordinate'), and not be confused with 'struct
attribute'.

Suggested-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/168332213518.2189163.18377767521423011290.stgit@djiang5-mobl3
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/node.c

index b46db17..2cada01 100644 (file)
@@ -162,15 +162,15 @@ free:
 }
 
 #ifdef CONFIG_HMEM_REPORTING
-#define ACCESS_ATTR(name)                                              \
-static ssize_t name##_show(struct device *dev,                         \
+#define ACCESS_ATTR(property)                                          \
+static ssize_t property##_show(struct device *dev,                     \
                           struct device_attribute *attr,               \
                           char *buf)                                   \
 {                                                                      \
        return sysfs_emit(buf, "%u\n",                                  \
-                         to_access_nodes(dev)->hmem_attrs.name);       \
+                         to_access_nodes(dev)->hmem_attrs.property);   \
 }                                                                      \
-static DEVICE_ATTR_RO(name)
+static DEVICE_ATTR_RO(property)
 
 ACCESS_ATTR(read_bandwidth);
 ACCESS_ATTR(read_latency);