regmap: Avoid namespace collision within macro & tidy up
authorRamesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
Mon, 3 Jul 2017 11:04:21 +0000 (12:04 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 10 Jul 2017 18:19:16 +0000 (19:19 +0100)
Renamed variable "timeout" to "__timeout" & "pollret" to "__ret" to
avoid namespace collision. Tidy up macro arguments with parentheses.

Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
include/linux/regmap.h

index e886492..6e1df5e 100644 (file)
@@ -120,23 +120,24 @@ struct reg_sequence {
  */
 #define regmap_read_poll_timeout(map, addr, val, cond, sleep_us, timeout_us) \
 ({ \
-       ktime_t timeout = ktime_add_us(ktime_get(), timeout_us); \
-       int pollret; \
+       ktime_t __timeout = ktime_add_us(ktime_get(), timeout_us); \
+       int __ret; \
        might_sleep_if(sleep_us); \
        for (;;) { \
-               pollret = regmap_read((map), (addr), &(val)); \
-               if (pollret) \
+               __ret = regmap_read((map), (addr), &(val)); \
+               if (__ret) \
                        break; \
                if (cond) \
                        break; \
-               if (timeout_us && ktime_compare(ktime_get(), timeout) > 0) { \
-                       pollret = regmap_read((map), (addr), &(val)); \
+               if ((timeout_us) && \
+                   ktime_compare(ktime_get(), __timeout) > 0) { \
+                       __ret = regmap_read((map), (addr), &(val)); \
                        break; \
                } \
                if (sleep_us) \
-                       usleep_range((sleep_us >> 2) + 1, sleep_us); \
+                       usleep_range(((sleep_us) >> 2) + 1, sleep_us); \
        } \
-       pollret ?: ((cond) ? 0 : -ETIMEDOUT); \
+       __ret ?: ((cond) ? 0 : -ETIMEDOUT); \
 })
 
 #ifdef CONFIG_REGMAP