[NFC] Minor fix for deferred diagnostics emitter
authorYaxun (Sam) Liu <yaxun.liu@amd.com>
Mon, 6 Apr 2020 17:52:47 +0000 (13:52 -0400)
committerYaxun (Sam) Liu <yaxun.liu@amd.com>
Mon, 6 Apr 2020 18:01:41 +0000 (14:01 -0400)
Differential Revision: https://reviews.llvm.org/D77028

clang/lib/Sema/Sema.cpp

index ff184aa..6c16661 100644 (file)
@@ -1555,7 +1555,7 @@ public:
       emitDeferredDiags(FD, Caller);
     // Do not revisit a function if the function body has been completely
     // visited before.
-    if (Done.count(FD))
+    if (!Done.insert(FD).second)
       return;
     InUsePath.insert(FD);
     UsePath.push_back(FD);
@@ -1564,7 +1564,6 @@ public:
     }
     UsePath.pop_back();
     InUsePath.erase(FD);
-    Done.insert(FD);
   }
 
   void checkRecordedDecl(Decl *D) {