intel_scu_ipc: return -EIO for error condition in busy_loop
authorHong Liu <hong.liu@intel.com>
Mon, 26 Jul 2010 09:06:12 +0000 (10:06 +0100)
committerMatthew Garrett <mjg@redhat.com>
Tue, 3 Aug 2010 13:50:33 +0000 (09:50 -0400)
Signed-off-by: Hong Liu <hong.liu@intel.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
drivers/platform/x86/intel_scu_ipc.c

index 84a2d4b..23b6d46 100644 (file)
@@ -148,7 +148,10 @@ static inline int busy_loop(void) /* Wait till scu status is busy */
                        return -ETIMEDOUT;
                }
        }
-       return (status >> 1) & 1;
+       if ((status >> 1) & 1)
+               return -EIO;
+
+       return 0;
 }
 
 /* Read/Write power control(PMIC in Langwell, MSIC in PenWell) registers */