mac80211: do not access the IV when it was stripped
authorXing Song <xing.song@mediatek.com>
Mon, 1 Nov 2021 02:46:57 +0000 (10:46 +0800)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 15 Nov 2021 09:54:37 +0000 (10:54 +0100)
ieee80211_get_keyid() will return false value if IV has been stripped,
such as return 0 for IP/ARP frames due to LLC header, and return -EINVAL
for disassociation frames due to its length... etc. Don't try to access
it if it's not present.

Signed-off-by: Xing Song <xing.song@mediatek.com>
Link: https://lore.kernel.org/r/20211101024657.143026-1-xing.song@mediatek.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/rx.c

index fc5c608d02e21658130fb1ae24d26fdcf21190b5..6360c664259ffb7761fb155fc93ade214ba51306 100644 (file)
@@ -1952,7 +1952,8 @@ ieee80211_rx_h_decrypt(struct ieee80211_rx_data *rx)
                int keyid = rx->sta->ptk_idx;
                sta_ptk = rcu_dereference(rx->sta->ptk[keyid]);
 
-               if (ieee80211_has_protected(fc)) {
+               if (ieee80211_has_protected(fc) &&
+                   !(status->flag & RX_FLAG_IV_STRIPPED)) {
                        cs = rx->sta->cipher_scheme;
                        keyid = ieee80211_get_keyid(rx->skb, cs);