webrtc_source: Check if the extra field of media packet is gstreamer buffer 02/258902/4
authorSangchul Lee <sc11.lee@samsung.com>
Thu, 27 May 2021 10:22:51 +0000 (19:22 +0900)
committerSangchul Lee <sc11.lee@samsung.com>
Tue, 1 Jun 2021 03:03:14 +0000 (12:03 +0900)
It is added to avoid failure on 'push-buffer' signal function when the extra
field of the media packet is not a gstreamer buffer.

[Version] 0.1.174
[Issue Type] Improvement

Change-Id: I30643df4cc86bedf0ff116c58eff1893659d947c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
packaging/capi-media-webrtc.spec
src/webrtc_source.c

index e673c03450e6efd54e7237584cf230a26ec7c954..c455e4d5fed4deb99a214fc891aeeb7e75d38b41 100644 (file)
@@ -1,6 +1,6 @@
 Name:       capi-media-webrtc
 Summary:    A WebRTC library in Tizen Native API
-Version:    0.1.173
+Version:    0.1.174
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
index 2a4bbdae43ea480092978839a2fef3eac87f6916..6a8d93fe5a30ee2614792e5960230e3de974cd00 100644 (file)
@@ -1920,10 +1920,9 @@ int _push_media_packet(webrtc_s *webrtc, unsigned int source_id, media_packet_h
                return WEBRTC_ERROR_NONE;
        }
 
-       /* FIXME: we assume that extra field has gstreamer buffer pointer */
        ret = media_packet_get_extra(packet, (void **)&buffer);
        RET_VAL_IF(ret != MEDIA_PACKET_ERROR_NONE, WEBRTC_ERROR_INVALID_OPERATION, "failed to media_packet_get_extra()");
-       if (buffer) {
+       if (GST_IS_BUFFER(buffer)) {
                media_format_h format;
 
                ret = media_packet_get_format(packet, &format);
@@ -1934,7 +1933,6 @@ int _push_media_packet(webrtc_s *webrtc, unsigned int source_id, media_packet_h
                }
                media_format_unref(format);
 
-               /* FIXME: need more API to check if it is valid gstreamer buffer. */
                LOG_DEBUG("external gst buffer[%p]", buffer);
                g_signal_emit_by_name(G_OBJECT(appsrc), "push-buffer", buffer, &gst_ret, NULL);
                if (gst_ret != GST_FLOW_OK) {