Enforce "treat warning as error" policy for chromium-ewk

1. Remove top-level "-Dwerror=" gyp define from gyp_chromiumefl.sh.
This will let chromium targets use their own policy regarding whether to treat
warnings as error or ignore them.

2. Add '-Werror' cflag to chromium-ewk target.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=15612

Reviewed by: a1.gomes, g.czajkowski

Change-Id: Id2634bcb1958c53ddc53a4259404d3cf54047a66
Signed-off-by: SeungSeop Park <sns.park@samsung.com>

diff --git a/tizen_src/build/gyp_chromiumefl.sh b/tizen_src/build/gyp_chromiumefl.sh
index 309fd23a82a83b44bec063950e5170d6c172ddff..e41769bc303ccf52b9c20ce255a5f8344cb77ed1 100755 (executable)
--- a/tizen_src/build/gyp_chromiumefl.sh
+++ b/tizen_src/build/gyp_chromiumefl.sh
@@ -113,7 +113,6 @@ add_arm_flags() {
 add_tizen_flags() {
   ADDITIONAL_GYP_PARAMETERS+="-Dbuilding_for_tizen=1
                               -Dtizen=1
-                              -Dwerror=
                               -Dpython_ver=$(getPythonVersion)
                               -Denable_basic_printing=1
                               -Denable_print_preview=1

diff --git a/tizen_src/ewk/efl_integration/efl_integration.gypi b/tizen_src/ewk/efl_integration/efl_integration.gypi
index 646cb5d4220faa91533891b383a44ae661f0fd12..47780d04d8e324deffd1186a43e8d2c6e8eff000 100644 (file)
--- a/tizen_src/ewk/efl_integration/efl_integration.gypi
+++ b/tizen_src/ewk/efl_integration/efl_integration.gypi
@@ -86,6 +86,14 @@
       # Symbol visibility controled by chromium-ewk.filter
       '-fvisibility=hidden',
     ],
+    'cflags/': [
+      # Treat warning as error for this target.
+      # It needs to be included by means of pattern list because '-Werror' cflag
+      # will be excluded in chromium side (src/build/common.gypi), and GYP
+      # processes pattern lists after exclusion lists.
+      # (ref: https://gyp.gsrc.io/docs/InputFormatReference.md#Processing-Order)
+      ['include', '-Werror'],
+    ],
     'conditions': [
       ['xwalk_link_against_chromium_ewk==0', {
         'variables': {