e_info_server: fix a coverity issue not checking return of tbm_surface_map. 89/217689/3
authorSeunghun Lee <shiin.lee@samsung.com>
Wed, 13 Nov 2019 09:15:51 +0000 (18:15 +0900)
committerSooChan Lim <sc1.lim@samsung.com>
Wed, 13 Nov 2019 10:03:51 +0000 (10:03 +0000)
Change-Id: I9005d9e25de04689b61d2984c94a30544892b85f

src/bin/e_info_server.c

index a007bd6..81937b6 100644 (file)
@@ -6525,6 +6525,7 @@ e_info_server_dump_client(E_Client *ec, char *fname)
    int w = 0, h = 0;
    Ecore_Evas *ee = NULL;
    Evas_Object *img = NULL;
+   int res;
 
    if (!ec) return;
    if (e_client_util_ignored_get(ec)) return;
@@ -6550,7 +6551,9 @@ e_info_server_dump_client(E_Client *ec, char *fname)
 
         EINA_SAFETY_ON_NULL_RETURN(tbm_surface);
         memset(&surface_info, 0, sizeof(tbm_surface_info_s));
-        tbm_surface_map(tbm_surface, TBM_SURF_OPTION_READ, &surface_info);
+        res = tbm_surface_map(tbm_surface, TBM_SURF_OPTION_READ, &surface_info);
+        if (res != TBM_SURFACE_ERROR_NONE)
+          return;
 
         data = surface_info.planes[0].ptr;
         w = surface_info.planes[0].stride / 4;
@@ -6563,7 +6566,9 @@ e_info_server_dump_client(E_Client *ec, char *fname)
 
         EINA_SAFETY_ON_NULL_RETURN(tbm_surface);
         memset(&surface_info, 0, sizeof(tbm_surface_info_s));
-        tbm_surface_map(tbm_surface, TBM_SURF_OPTION_READ, &surface_info);
+        res = tbm_surface_map(tbm_surface, TBM_SURF_OPTION_READ, &surface_info);
+        if (res != TBM_SURFACE_ERROR_NONE)
+          return;
 
         data = surface_info.planes[0].ptr;
         w = surface_info.planes[0].stride / 4;