Fixed #6632
authorakallabeth <akallabeth@posteo.net>
Thu, 3 Dec 2020 06:22:17 +0000 (07:22 +0100)
committerakallabeth <akallabeth@posteo.net>
Thu, 3 Dec 2020 08:34:37 +0000 (09:34 +0100)
(cherry picked from commit ceb0e8b4f1facb58849b2573fe60e3e512879a77)

winpr/libwinpr/file/generic.c
winpr/libwinpr/utils/image.c

index 9f6dc9f..1f8bf99 100644 (file)
@@ -361,7 +361,6 @@ BOOL ReadFileEx(HANDLE hFile, LPVOID lpBuffer, DWORD nNumberOfBytesToRead,
 
        WLog_ERR(TAG, "ReadFileEx operation not implemented");
        return FALSE;
-       return TRUE;
 }
 
 BOOL ReadFileScatter(HANDLE hFile, FILE_SEGMENT_ELEMENT aSegmentArray[], DWORD nNumberOfBytesToRead,
index a1155e5..d3a150c 100644 (file)
@@ -163,7 +163,7 @@ int winpr_bitmap_write(const char* filename, const BYTE* data, int width, int he
 
        bmp_header = winpr_bitmap_construct_header(width, height, bpp);
        if (!bmp_header)
-               return -1;
+               goto fail;
 
        if (fwrite(bmp_header, WINPR_IMAGE_BMP_HEADER_LEN, 1, fp) != 1 ||
            fwrite((void*)data, img_size, 1, fp) != 1)