dmaengine: fsl-qdma: fix duplicated argument to &&
authorChen Zhou <chenzhou10@huawei.com>
Mon, 20 Jan 2020 12:58:43 +0000 (20:58 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Feb 2020 07:36:29 +0000 (08:36 +0100)
[ Upstream commit 4b048178854da11656596d36a107577d66fd1e08 ]

There is duplicated argument to && in function fsl_qdma_free_chan_resources,
which looks like a typo, pointer fsl_queue->desc_pool also needs NULL check,
fix it.
Detected with coccinelle.

Fixes: b092529e0aa0 ("dmaengine: fsl-qdma: Add qDMA controller driver for Layerscape SoCs")
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Reviewed-by: Peng Ma <peng.ma@nxp.com>
Tested-by: Peng Ma <peng.ma@nxp.com>
Link: https://lore.kernel.org/r/20200120125843.34398-1-chenzhou10@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/dma/fsl-qdma.c

index 8979208..95cc025 100644 (file)
@@ -304,7 +304,7 @@ static void fsl_qdma_free_chan_resources(struct dma_chan *chan)
 
        vchan_dma_desc_free_list(&fsl_chan->vchan, &head);
 
-       if (!fsl_queue->comp_pool && !fsl_queue->comp_pool)
+       if (!fsl_queue->comp_pool && !fsl_queue->desc_pool)
                return;
 
        list_for_each_entry_safe(comp_temp, _comp_temp,