[EFL] Change ewk_settings_icon_database_icon_object_add to proper API name.

https://bugs.webkit.org/show_bug.cgi?id=82438

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-04-04
Reviewed by Andreas Kling.

The purpose of ewk_settings_icon_database_icon_object_add is to get icon
for the given URL. This function doesn't add anything to database.
Documentation and API name are adjusted.

* ewk/ewk_settings.cpp:
(ewk_settings_icon_database_icon_object_get):
* ewk/ewk_settings.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebKit/efl/ChangeLog b/Source/WebKit/efl/ChangeLog
index 69e3ef3..a9bfa4c 100644 (file)
--- a/Source/WebKit/efl/ChangeLog
+++ b/Source/WebKit/efl/ChangeLog
@@ -1,3 +1,18 @@
+2012-04-04  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
+
+        [EFL] Change ewk_settings_icon_database_icon_object_add to proper API name.
+        https://bugs.webkit.org/show_bug.cgi?id=82438
+
+        Reviewed by Andreas Kling.
+
+        The purpose of ewk_settings_icon_database_icon_object_add is to get icon
+        for the given URL. This function doesn't add anything to database.
+        Documentation and API name are adjusted.
+
+        * ewk/ewk_settings.cpp:
+        (ewk_settings_icon_database_icon_object_get):
+        * ewk/ewk_settings.h:
+
 2012-04-03  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
 
         [EFL] DRT support for setInteractiveFormValidationEnabled

diff --git a/Source/WebKit/efl/ewk/ewk_settings.cpp b/Source/WebKit/efl/ewk/ewk_settings.cpp
index d13b39e..00e97be 100644 (file)
--- a/Source/WebKit/efl/ewk/ewk_settings.cpp
+++ b/Source/WebKit/efl/ewk/ewk_settings.cpp
@@ -228,7 +228,7 @@ cairo_surface_t* ewk_settings_icon_database_icon_surface_get(const char* url)
     return icon->nativeImageForCurrentFrame();
 }
 
-Evas_Object* ewk_settings_icon_database_icon_object_add(const char* url, Evas* canvas)
+Evas_Object* ewk_settings_icon_database_icon_object_get(const char* url, Evas* canvas)
 {
     EINA_SAFETY_ON_NULL_RETURN_VAL(url, 0);
     EINA_SAFETY_ON_NULL_RETURN_VAL(canvas, 0);

diff --git a/Source/WebKit/efl/ewk/ewk_settings.h b/Source/WebKit/efl/ewk/ewk_settings.h
index cce9a5a..8c2200e 100644 (file)
--- a/Source/WebKit/efl/ewk/ewk_settings.h
+++ b/Source/WebKit/efl/ewk/ewk_settings.h
@@ -175,7 +175,7 @@ EAPI Eina_Bool        ewk_settings_icon_database_clear(void);
 EAPI cairo_surface_t *ewk_settings_icon_database_icon_surface_get(const char *url);
 
 /**
- * Creates Evas_Object of type image representing the given URL.
+ * Gets image representing the given URL.
  *
  * This is an utility function that creates an Evas_Object of type
  * image set to have fill always match object size
@@ -184,13 +184,16 @@ EAPI cairo_surface_t *ewk_settings_icon_database_icon_surface_get(const char *ur
  * @note In order to have this working, one must open icon database
  *       with ewk_settings_icon_database_path_set().
  *
+ * @note The "load,finished" signal doesn't guarantee that icons are completely loaded and
+ *        saved to database. Icon can be taken after the "icon,received" signal.
+ *
  * @param url which url to query icon
  * @param canvas evas instance where to add resulting object
  *
  * @return newly allocated Evas_Object instance or @c 0 on
  *         errors. Delete the object with evas_object_del().
  */
-EAPI Evas_Object     *ewk_settings_icon_database_icon_object_add(const char *url, Evas *canvas);
+EAPI Evas_Object     *ewk_settings_icon_database_icon_object_get(const char *url, Evas *canvas);
 
 /**
  * Sets the path where the application cache will be stored.