tests/elm: fix a couple unit tests to use event starter helper function
authorMike Blumenkrantz <zmike@samsung.com>
Fri, 19 Jul 2019 19:46:35 +0000 (15:46 -0400)
committerSangHyeon Jade Lee <sh10233.lee@samsung.com>
Tue, 23 Jul 2019 05:04:43 +0000 (14:04 +0900)
these tests seem to have relied upon a callback being triggered which
would call ecore_main_loop_quit() prior to ecore_main_loop_begin() starting
the main loop

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9365

src/tests/elementary/elm_test_genlist.c
src/tests/elementary/elm_test_widget_focus.c

index 8715d3b..ce62580 100644 (file)
@@ -159,7 +159,7 @@ EFL_START_TEST(elm_genlist_test_item_content)
    evas_object_show(genlist);
    evas_object_show(win);
 
-   ecore_main_loop_begin();
+   get_me_to_those_events(win);
 
    end = elm_object_item_part_content_get(it, "elm.swallow.end");
    parent = elm_object_parent_widget_get(end);
index 0fb0a79..46814d0 100644 (file)
@@ -157,7 +157,6 @@ EFL_START_TEST(elm_test_widget_focus_simple_widget)
 
    box = elm_box_add(win);
    elm_win_resize_object_add(win, box);
-   evas_object_show(win);
    evas_object_show(box);
 
    resettor = o = elm_button_add(win);
@@ -177,13 +176,9 @@ EFL_START_TEST(elm_test_widget_focus_simple_widget)
       }
    evas_object_resize(win, 200, 200);
 
-   //I have no idea why this is needed - but if this here is not done,
-   // then elements that are part of a layout will NOT be shown even if
-   // the window and layout is shown
-   evas_object_hide(win);
    evas_object_show(win);
 
-   ecore_main_loop_begin();
+   get_me_to_those_events(win);
 
    for (int i = 0; simple_widgets[i].name; ++i)
       {