Enable FEC driver to retrieve PHY address from device tree
authorMartyn Welch <martyn@welchs.me.uk>
Tue, 11 Dec 2018 11:34:45 +0000 (11:34 +0000)
committerStefano Babic <sbabic@denx.de>
Mon, 28 Jan 2019 11:47:15 +0000 (12:47 +0100)
Currently if we have more than one phy on the MDIO bus, we do not have a
good mechanism for determining which should be used at runtime. Enable the
FEC driver to determine the address for the PHY from the device tree.

Signed-off-by: Martyn Welch <martyn.welch@collabora.com>
Reviewed-by: Lukasz Majewski <lukma@denx.de>
drivers/net/fec_mxc.c

index 32fb34b..1a59026 100644 (file)
@@ -1264,11 +1264,32 @@ static const struct eth_ops fecmxc_ops = {
        .read_rom_hwaddr        = fecmxc_read_rom_hwaddr,
 };
 
+static int device_get_phy_addr(struct udevice *dev)
+{
+       struct ofnode_phandle_args phandle_args;
+       int reg;
+
+       if (dev_read_phandle_with_args(dev, "phy-handle", NULL, 0, 0,
+                                      &phandle_args)) {
+               debug("Failed to find phy-handle");
+               return -ENODEV;
+       }
+
+       reg = ofnode_read_u32_default(phandle_args.node, "reg", 0);
+
+       return reg;
+}
+
 static int fec_phy_init(struct fec_priv *priv, struct udevice *dev)
 {
        struct phy_device *phydev;
+       int addr;
        int mask = 0xffffffff;
 
+       addr = device_get_phy_addr(dev);
+       if (addr >= 0)
+               mask = 1 << addr;
+
 #ifdef CONFIG_FEC_MXC_PHYADDR
        mask = 1 << CONFIG_FEC_MXC_PHYADDR;
 #endif