Fix SVACE issue (WGID-265468) 12/170512/2 accepted/tizen/unified/20180222.080207 submit/tizen/20180221.115004
authorSeonah Moon <seonah1.moon@samsung.com>
Tue, 20 Feb 2018 11:01:03 +0000 (20:01 +0900)
committerSeonah Moon <seonah1.moon@samsung.com>
Wed, 21 Feb 2018 01:46:03 +0000 (10:46 +0900)
DEAD_STRING_REF

Change-Id: I04b2c31f9cfdda76ab91078e7dc79cb1df2c393b
Signed-off-by: Seonah Moon <seonah1.moon@samsung.com>
packaging/org.tizen.download-manager.spec
src/download-manager-notification.cpp

index 9d21539594ff632987dfba2344edabaa7f261d87..898f58c676c4a2aabd6e711d96f3945038448435 100755 (executable)
@@ -1,7 +1,7 @@
 %define _ux_define tizen2.3
 Name:  org.tizen.download-manager
 Summary:       Application for support of the content download
-Version:       0.3.27
+Version:       0.3.28
 Release:       1
 License:       Flora-1.1
 Group:         misc
index f06b836e9417b8e065f1bbbcd60a8a96b9265410..b6b536f7db5c62cbe6ff6e238b0e248f02891698 100755 (executable)
@@ -52,7 +52,6 @@ void DownloadNoti::updateCB(void *data)
 
 void DownloadNoti::updateFromItem()
 {
-       string msg;
        if (!m_item)
                return;
 
@@ -127,7 +126,7 @@ void DownloadNoti::freeNotiData(notification_h notiHandle)
        if (notiHandle) {
                err = notification_free(notiHandle);
                if (err != NOTIFICATION_ERROR_NONE)
-                       DM_LOGE("Fail to free noti data [%d]",err);
+                       DM_LOGE("Fail to free noti data [%d]", err);
                notiHandle = NULL;
        }
 }
@@ -140,7 +139,7 @@ void DownloadNoti::deleteNotiData(notification_h notiHandle)
        if (notiHandle) {
                err = notification_delete(notiHandle);
                if (err != NOTIFICATION_ERROR_NONE)
-                       DM_LOGE("Fail to delete noti data [%d]",err);
+                       DM_LOGE("Fail to delete noti data [%d]", err);
        }
 }
 
@@ -180,9 +179,7 @@ void DownloadNoti::addOngoingNoti()
 
        if(!strcmp(tmpStr.c_str(), DM_BODY_TEXT_NO_NAME))
        {
-               const char *url = NULL;
-               url=m_item->getUrl().c_str();
-               err = notification_set_text(notiHandle, NOTIFICATION_TEXT_TYPE_CONTENT, url, NULL, NOTIFICATION_VARIABLE_TYPE_NONE);
+               err = notification_set_text(notiHandle, NOTIFICATION_TEXT_TYPE_CONTENT, m_item->getUrl().c_str(), NULL, NOTIFICATION_VARIABLE_TYPE_NONE);
                if (err != NOTIFICATION_ERROR_NONE)
                {
                        DM_LOGE("Fail to set content [%d]", err);
@@ -235,7 +232,7 @@ void DownloadNoti::addOngoingNoti()
                freeNotiData(notiHandle);
                return;
        }
-       char buff[MAX_BUF_LEN] = {0,};
+       char buff[MAX_BUF_LEN] = {0, };
        snprintf(buff, MAX_BUF_LEN, "%u", m_item->getHistoryId());
        if (app_control_add_extra_data(handle, KEY_DOWNLOADING_HISTORYID,
                        (const char *)buff) != APP_CONTROL_ERROR_NONE) {
@@ -341,7 +338,7 @@ string DownloadNoti::convertSizeStr(unsigned long long size)
 
        str[63] = '\0';
        temp = string(str);
-       DM_LOGV("size[%ld]",size);
+       DM_LOGV("size[%ld]", size);
        return temp;
 }
 
@@ -473,7 +470,7 @@ void DownloadNoti::addCompleteNoti()
        }
 #endif
 
-    err = notification_set_image(notiHandle, NOTIFICATION_IMAGE_TYPE_ICON,DM_NOTI_COMPLETED_QUICKPANNEL_ICON_PATH);
+    err = notification_set_image(notiHandle, NOTIFICATION_IMAGE_TYPE_ICON, DM_NOTI_COMPLETED_QUICKPANNEL_ICON_PATH);
     if (err != NOTIFICATION_ERROR_NONE) {
                 DM_LOGE("Fail to set icon [%d]", err);
                 freeNotiData(notiHandle);
@@ -581,7 +578,7 @@ void DownloadNoti::addFailedNoti()
                freeNotiData(notiHandle);
                return;
        }
-       char buff[MAX_BUF_LEN] = {0,};
+       char buff[MAX_BUF_LEN] = {0, };
        if (app_control_set_app_id(handle, PACKAGE_NAME) !=
                        APP_CONTROL_ERROR_NONE) {
                DM_LOGE("Fail to app_control set pkgname");