flacenc: fix other icon counter check
authorTim-Philipp Müller <tim@centricular.com>
Sat, 14 Jan 2017 15:27:19 +0000 (15:27 +0000)
committerTim-Philipp Müller <tim@centricular.com>
Sat, 14 Jan 2017 15:27:37 +0000 (15:27 +0000)
It's never going to be 0 if we first increment and then check.

ext/flac/gstflacenc.c

index 8a5ec78..d31de07 100644 (file)
@@ -661,7 +661,7 @@ gst_flac_enc_set_metadata (GstFlacEnc * flacenc, GstAudioInfo * info,
               && gst_structure_has_name (structure, "image/png")
               && png_icon_count++ == 0) {
             image_type = 1;
-          } else if (width <= 32 && height <= 32 && ++other_icon_count == 0) {
+          } else if (width <= 32 && height <= 32 && other_icon_count++ == 0) {
             image_type = 2;
           } else {
             image_type = 0;     /* Other */