anv: Disallow UBO pushing for bindless shaders
authorJason Ekstrand <jason@jlekstrand.net>
Fri, 7 Aug 2020 03:31:02 +0000 (22:31 -0500)
committerMarge Bot <eric+marge@anholt.net>
Tue, 22 Jun 2021 21:09:25 +0000 (21:09 +0000)
They don't really have push constants.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637>

src/intel/vulkan/anv_nir_compute_push_layout.c

index 3c41b1f..da19ab3 100644 (file)
@@ -76,7 +76,8 @@ anv_nir_compute_push_layout(const struct anv_physical_device *pdevice,
 
    const bool push_ubo_ranges =
       pdevice->info.verx10 >= 75 &&
-      has_const_ubo && nir->info.stage != MESA_SHADER_COMPUTE;
+      has_const_ubo && nir->info.stage != MESA_SHADER_COMPUTE &&
+      !brw_shader_stage_is_bindless(nir->info.stage);
 
    if (push_ubo_ranges && robust_buffer_access) {
       /* We can't on-the-fly adjust our push ranges because doing so would